Description Christian Damus 2016-05-17 17:54:37 EDT

May 17 2016 build of Papyrus Neon

When the NattablePropertyEditor initializes the table instance in the workspace metadata area, under one particular circumstance it will attempt to modify the table-configuration model that defines it.  This is invalid for two reasons:

* when the table is first being created, the table's private editing domain in which it loaded the configuration model does not have a read/write transaction, so the modification throws an IllegalStateException that prevents the creation of the actual table widget

* the table editor should not be attempting to modify its configuration model, anyways.  This configuration is a static model deployed in a plug-in bundle

The problem is in the protected Table createTable(EObject, EStructuralFeature) method, here:

	if (null != synchronizedFeature) {
		TableHeaderAxisConfiguration rowHeaderAxisconfig = tableConfiguration.getRowHeaderAxisConfiguration();
		for (IAxisConfiguration axisConfig : rowHeaderAxisconfig.getOwnedAxisConfigurations()) {
			if (axisConfig instanceof EStructuralFeatureValueFillingConfiguration) {
				((EStructuralFeatureValueFillingConfiguration) axisConfig).setListenFeature(synchronizedFeature);
			}
		}
	}

It's the setListenFeature(...) call that's invalid.  The editor should just trust that the configuration model already references the 'synchronizedFeature' as the "listen feature" of the axis configuration, because it wouldn't make any sense for it to be a different feature.

Steps to reproduce:

You can either go the hard way and create a table-configuration model that includes an EStructuralFeatureValueFillingConfiguration in its row header axis configuration and use that configuration in a new property sheet widget cooked up for some UML metaclass (with all of the attendant environment and context models and XWT files) or you can check out patch set 25 of Gerrit review 66384 into a Papyrus-RT workspace:

    git fetch https://<user>@git.eclipse.org/r/a/papyrus-rt/org.eclipse.papyrus-rt refs/changes/84/66384/25 && git checkout FETCH_HEAD

and try to see the properties of a protocol message in the "Real Time" tab.