489489 – [launch] Can only use final class fields in classes derived from GdbLaunchDelegate

Bug 489489 - [launch] Can only use final class fields in classes derived from GdbLaunchDelegate

Summary: [launch] Can only use final class fields in classes derived from GdbLaunchDel...

Status:	RESOLVED FIXED

Alias:	None

Product:	TCF
Classification:	Tools
Component:	Target (show other bugs)
Version:	unspecified
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	1.4
Assignee:	Project Inbox
QA Contact:	Uwe Stieber

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-03-12 15:01 EST by Jonah Graham
Modified:	2016-03-14 03:02 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jonah Graham

2016-03-12 15:01:07 EST

TCF extends GdbLaunchDelegate and as part of Bug 456116 GdbLaunchDelegate was cleaned up to remove use of non-final field accesses.

This bug is to track fixing the same issue for TCF. In part the API of GdbLaunchDelegate has changed so there is an immediate problem for Neon. Longer term it may be desirable to fix the underlying issues that Bug 456116 talks about as it probably affects TCF too.

Comment 1 Eclipse Genie

2016-03-12 15:07:13 EST

New Gerrit change created: https://git.eclipse.org/r/68276

Comment 2 Jonah Graham

2016-03-13 11:29:13 EDT

From Bug 456116 Comment 9:
> The change in GdbLaunchDelegate needs to be resolved in either CDT side or
> TCF side. To this end I provide two possible implementations.
> 
> 1) Add cleanupLaunch() back in to CDT, but deprecated and never called by
> CDT. This is https://git.eclipse.org/r/68295 
> 2) Copy cleanupLaunch into TCF, but deprecate it until TCF no longer wants
> to support CDT < 9.0 at which point it should be removed and replaced with
> the new API in CDT. This is https://git.eclipse.org/r/68276
> 
> Someone needs to decide which one of these options is the best fit going
> forward.

Comment 3 Eclipse Genie

2016-03-14 03:00:23 EDT

Gerrit change https://git.eclipse.org/r/68276 was merged to [master].
Commit: http://git.eclipse.org/c/tcf/org.eclipse.tcf.git/commit/?id=6eb1e1da299e24a9a699c88fbe735a5db3bd3018

Comment 4 Uwe Stieber

2016-03-14 03:02:30 EDT

Merged. Thanks for the contribution.