487121 – Remove "connect" button from the Debug View toolbar

Bug 487121 - Remove "connect" button from the Debug View toolbar

Summary: Remove "connect" button from the Debug View toolbar

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug (show other bugs)
Version:	Next
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	9.0.0
Assignee:	Marc Khouzam
QA Contact:	Doug Schaefer

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2016-02-03 09:12 EST by Marc Dumais
Modified:	2016-03-03 10:03 EST (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc Dumais

2016-02-03 09:12:23 EST

We have had some recent discussions about removing the "Connect to a Process" (i.e. "attach") button from the Debug view. 

The action would still be available from the context menu, which we think is more appropriate.

Comment 1 Marc Khouzam

2016-02-04 15:50:20 EST

A similar button is being added to the OS Resources view in bug 486521.  However, this new button will immediately try to connect to the selected processes; this is different than the behaviour of that button in the Debug view which pops-up a dialog.

I think having it in the OS Resources view has more potential but being inconsistent is confusing.  Removing the button from the DV, as suggested, will solve this confusion.

Comment 2 Teodor Madan

2016-02-04 18:08:36 EST

+1

Existing placement in DV toolbar is not intuitive as it does not have immediate meaning of either a) "connect selected GDB debugger to a process" or b) "connect selected process to GDB"  

a) would be implied through leaving action in context menu
b) would be implied through OS Resources view

Comment 3 Eclipse Genie

2016-03-02 16:41:03 EST

New Gerrit change created: https://git.eclipse.org/r/67699

Comment 4 Eclipse Genie

2016-03-03 10:02:22 EST

Gerrit change https://git.eclipse.org/r/67699 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=038783cf5f89f64bd8cc847a19a52980adf52c2d

Comment 5 Marc Khouzam

2016-03-03 10:03:10 EST

I've updated the N&N with this change.

Comment 6 Marc Khouzam

2016-03-03 10:03:19 EST

(In reply to Marc Khouzam from comment #5)
> I've updated the N&N with this change.

https://wiki.eclipse.org/CDT/User/NewIn90#Connect_button_removed_from_Debug_toolbar