Bug 478814 - Replace PHP Explorer by common Project Explorer
Summary: Replace PHP Explorer by common Project Explorer
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate, usability
Depends on: 480374 480376 494821 501049 501273 501274 501296 501959 501969 501988 502136 505988 505989 505993 514693
Blocks:
  Show dependency tree
 
Reported: 2015-10-01 10:12 EDT by Dawid Pakula CLA
Modified: 2020-05-14 13:24 EDT (History)
4 users (show)

See Also:


Attachments
Problem in project explorer (332.94 KB, video/mp4)
2018-06-08 11:09 EDT, Michele Locati CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2015-10-01 10:12:30 EDT
To reduce complexity and maintenance code, we could investigate possibility to replace php explorer by common project explorer.  Off course not today, not tomorrow.

Benefits:
1. Common stable api for tree extensions. For example bug 344253 and bug 356629 will be fixed out of box.
2. Code will be reduced to small content extensions.
3. Better usability for those who work on many languages.
4. Hierarchical project presentation
5. "Project Explorer" is better name than "PHP Explorer"

What we sacrifice:
1. Full content control
2. I'm not sure, but probably buildpath/library icons.

Things to do:
1. Current refactoring support have to be migrated to common
2. Introduce group by namespace in Project Explorer
3. Add "PHP Include Path" and "PHP Language Library" and related to tree
Comment 1 Michal Niewrzal CLA 2015-10-01 10:23:23 EDT
I agree. There is similar discussion in JDT (bug 427897).

Maybe we can divide it into smaller tasks and later just change default explorer for PHP perspective?
Comment 2 Kaloyan Raev CLA 2015-10-01 10:30:08 EDT
Big +1 from me.
Comment 3 Dawid Pakula CLA 2015-10-01 12:41:10 EDT
(In reply to Michal Niewrzal from comment #1)
> I agree. There is similar discussion in JDT (bug 427897).
Yes, and some  problems aren't linked. For example project explorer haven't 'Window Working Sets' indicator.

> Maybe we can divide it into smaller tasks and later just change default
> explorer for PHP perspective?
We have to and this bug should be umbrella for Project Explorer extensions. Initial integration was done in bug 353453. 

If DLTK members are interested, would be good to keep most of things on DLTK Core side. Or backport later.
Comment 4 Dawid Pakula CLA 2016-09-07 08:54:12 EDT
How about:
1. Switch to Project Explorer on fresh installs since 4.2 (if bug 494821 will be resolved).
2. Drop in 5.0 if no blockers?
Comment 5 Michal Niewrzal CLA 2016-09-07 09:59:13 EDT
Project Explorer still miss more then drag&drop:
* Group by namespaces
* Default 'Other Projects' working set (useful in my opinion)
* I remember smaller issues in Project Explorer itself but I don't remember numbers

I think we can make an experiment and switch to Project Explorer after fixing bug 494821 and after release 4.1. About dropping PHP Explorer completely we can think later :)

Btw, are you using Project Explorer on daily basis?
Comment 6 Dawid Pakula CLA 2016-09-07 10:19:11 EDT
(In reply to Michal Niewrzal from comment #5)
> Project Explorer still miss more then drag&drop:
> * Group by namespaces
Group by namespaces is still very buggy and on larger project useless in dalily work. Should be rewritten after bug 472758 fix.

> * Default 'Other Projects' working set (useful in my opinion)
You mean "Window Working Set"? This inconsistency driving me crazy sometimes.

> * I remember smaller issues in Project Explorer itself but I don't remember
> numbers
I also have something in my mind. When one of them appear I always checking "perspectives" :P

> I think we can make an experiment and switch to Project Explorer after
> fixing bug 494821 and after release 4.1. About dropping PHP Explorer
> completely we can think later :)
+1

> Btw, are you using Project Explorer on daily basis
Yes, when I forgot switch from JavaScript perspective, and I don't need PDT cmd+shift+t. In general, after select "window working set" in all views, I mostly use cmd+shift+r / cmd+shift+t to navigate and mylyn task list to manipulate visible projects.
Comment 7 Michal Niewrzal CLA 2016-10-11 18:27:09 EDT
Hmm I think we are more or less good to go ;) I'm still thinking about bug 501049 because after removing ISourceModule and IScriptFolder binding is working mainly for PHP Editor only ;) but I think is not critical.

Any comments, objections?
Comment 8 Eclipse Genie CLA 2016-10-15 09:54:40 EDT
New Gerrit change created: https://git.eclipse.org/r/83299
Comment 10 Eclipse Genie CLA 2017-01-25 08:43:34 EST
New Gerrit change created: https://git.eclipse.org/r/89510
Comment 12 Eclipse Genie CLA 2018-03-31 11:14:34 EDT
New Gerrit change created: https://git.eclipse.org/r/120541
Comment 14 Michele Locati CLA 2018-06-08 11:09:44 EDT
Created attachment 274401 [details]
Problem in project explorer
Comment 15 Michele Locati CLA 2018-06-08 11:12:19 EDT
I find Project Explorer buggy (see attachment https://bugs.eclipse.org/bugs/attachment.cgi?id=274401 ).  I had it in Eclipse Oxygen, but upgrading to Photon RC2 didn't solved this issue. Where should I report this bug?
Comment 16 Dawid Pakula CLA 2018-06-08 18:02:32 EDT
Please open fresh bug for PDT in bugzilla. It's related to PDT common explorer content provider, similar is bug 512222. 

I'll try introduce hotfix without revolution, revolution will be in 6.1 ;P
Comment 17 Michele Locati CLA 2018-06-09 08:36:47 EDT
> Please open fresh bug for PDT in bugzilla. It's related to PDT common explorer content provider, similar is bug 512222. 

Thanks! I wasn't sure if it was a PDT problem or a platform problem. Here it is: https://bugs.eclipse.org/bugs/show_bug.cgi?id=535736