Community
Participate
Working Groups
Created attachment 256421 [details] Example of JDT ruler hovers with multiple markers The JDT editor provides an option to expand ruler icons on hover. This provides better interaction when there are multiple markers on a single source line as it allows for each one to be seen and selected separately. Additionally it always provides a toggle breakpoint option. It would be nice if the editor in CDT could provide a similar feature. This could also be enhanced to provided separate toggles for different breakpoint types (e.g. Dynamic-printf)
Note that bug 473577 improved the UX for multiple markers on a single line slightly, by having a click on the ruler be handled by the first marker that wants to handle it, instead of just by the top-most marker (and having the click do nothing if the top-most marker doesn't handle it). That said, I agree that there is room for further improvement, and what you suggest here would be helpful.
I plan on looking into this, hopefully reusing the JDT code as much as possible.
I've started looking at this and there are some changes needed from the JDT behaviour to accommodate CDT annotations. Currently looking just into a port providing the same function as JDT then I will look at enhancing for multiple breakpoint types.
New Gerrit change created: https://git.eclipse.org/r/68169
(In reply to Eclipse Genie from comment #4) > New Gerrit change created: https://git.eclipse.org/r/68169 This patch-set contains an initial port of the JDT feature with some changes to improve the usability and fix a major bug I was seeing where clicking once would trigger 2 actions. Feedback on how it works would be good, and it needs testing on Linux as I removed the fix for https://bugs.eclipse.org/bugs/show_bug.cgi?id=165533 as it was causing the bug mentioned above. I tested on Windows & Mac but I am having issues getting my Linux VM to load the target platform so haven't tested on Linux yet.
Anyone going to get a chance to look at this?
(In reply to William Riley from comment #6) > Anyone going to get a chance to look at this? I personally have to put my efforts on the GDB Console for the next couple of weeks. Could you email the cdt-dev list with a screenshot and description of the feature to see if anyone can review it for 9.1?
At the CDT call today[1], we discussed and agreed to aim to make this the default for CDT 9.1. [1] https://wiki.eclipse.org/CDT/calls/Aug2016
Created attachment 263439 [details] Example showing feature as implemented in CDT by Gerrit 68169 Added screenshot showing this feature as implemented in https://git.eclipse.org/r/68169
Gerrit change https://git.eclipse.org/r/68169 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=c297330c9cdcf0c8ba32768476c2a96fc0b9a32c
William, Thank you for the submission. Gerrit 68169 (with CQ 11722) has been submitted. Over to you to finalize the changing of the default (Comment 8) and add the N&N. Thanks! Jonah
New Gerrit change created: https://git.eclipse.org/r/78334
(In reply to Jonah Graham from comment #11) > William, > > Thank you for the submission. Gerrit 68169 (with CQ 11722) has been > submitted. > > Over to you to finalize the changing of the default (Comment 8) and add the > N&N. > > Thanks! > Jonah I've pushed Gerrit change (78334) to change the default & added to N&N (currently waiting moderation).
Awesome! Thanks for the contribution!
Gerrit change https://git.eclipse.org/r/78334 was merged to [master]. Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=0f11ffff889b78d1bb54553c404347ac412c07a7
I have submitted the default change now too. Thanks William.
