Bug 473536 - [memory] Add a "Find Replace" menu option to the memory view
Summary: [memory] Add a "Find Replace" menu option to the memory view
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 8.8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.8.0   Edit
Assignee: Alvaro Sanchez-Leon CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-24 14:08 EDT by Alvaro Sanchez-Leon CLA
Modified: 2015-08-12 11:46 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2015-07-24 14:08:53 EDT
The memory view supports the Find / Replace option via the shortcut key Ctrl-F, 
however an menu entry is missing.
 This new entry will make the option easier to find.
Comment 1 Alvaro Sanchez-Leon CLA 2015-07-24 14:10:10 EDT
a proposed implementation will be submitted shortly
Comment 2 Eclipse Genie CLA 2015-07-24 15:14:15 EDT
New Gerrit change created: https://git.eclipse.org/r/52522
Comment 3 Marc Khouzam CLA 2015-07-28 13:11:41 EDT
The Find/Replace feature of the memory view was originally put in the memory view menu as part of bug 201322.  There is no information about the reasoning for that decision.  Could it be that a context-menu should usually be used when the action applies to the selection, while the view menu when the action is generic?

I don't think this is a rule followed consistently.  However, it makes me wonder if we should prefill the search box with the currently selected memory?
Comment 4 Eclipse Genie CLA 2015-07-30 11:18:14 EDT
WARNING: this patchset contains 1410 new lines of code and may require a Contribution Questionnaire (CQ) if the author is not a committer on the project. Please see:https://wiki.eclipse.org/Project_Management_Infrastructure/Creating_A_Contribution_Questionnaire
Comment 6 Alvaro Sanchez-Leon CLA 2015-07-31 08:32:51 EDT
The proposed solution is now merged into the master branch, 
see details at:

https://git.eclipse.org/r/52522
Comment 7 Marc Khouzam CLA 2015-07-31 09:05:12 EDT
Thanks Alvaro for this user-friendly improvement.
Can you put a note in the N&N for 8.8?
Comment 8 Marc Khouzam CLA 2015-08-10 11:06:48 EDT
(In reply to Marc Khouzam from comment #7)
> Thanks Alvaro for this user-friendly improvement.
> Can you put a note in the N&N for 8.8?

Friendly reminder :)
Comment 9 Alvaro Sanchez-Leon CLA 2015-08-11 08:53:08 EDT
(In reply to Marc Khouzam from comment #8)
> (In reply to Marc Khouzam from comment #7)
> > Thanks Alvaro for this user-friendly improvement.
> > Can you put a note in the N&N for 8.8?
> 
> Friendly reminder :)

Not a problem, I will add a note and screen shots tow the N&N for 8.8

I will post a note here when done.

Thanks for the reminder !
Comment 10 Alvaro Sanchez-Leon CLA 2015-08-12 11:46:25 EDT
The N&N for 8.8 are now updated with this enhancement, 

Thanks Marc !