Bug 466822 - Eclipse Mars release train participation - we should also contribute the source-feature for the Client API core
Summary: Eclipse Mars release train participation - we should also contribute the sour...
Status: CLOSED FIXED
Alias: None
Product: Jubula (Archived)
Classification: Technology
Component: Tools (show other bugs)
Version: 3.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 4.0   Edit
Assignee: Markus Tiede CLA
QA Contact: Oliver Goetz CLA
URL: http://dev.eclipse.org/mhonarc/lists/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-08 06:46 EDT by Markus Tiede CLA
Modified: 2016-05-19 03:38 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Tiede CLA 2015-05-08 06:46:43 EDT
When testing our M7 API artefacts I've noticed that we should also contribute the source-feature for the Client API core.
Comment 2 Oliver Goetz CLA 2015-05-22 07:59:07 EDT
This has been tested by SSt for JUB-1234
Comment 3 Markus Tiede CLA 2015-06-01 03:22:57 EDT
The latest repository reports indicate that:
 1. the contributed source feature JAR is unsigned - see [1]
 2. a couple of source bundles are missing the corresponding legal (about.html) file inclusion - see [2]

We should address both of these issues until Mars RC3 this week.

[1] https://hudson.eclipse.org/simrel/job/simrel.mars.runaggregator.CLEAN_BUILD/lastSuccessfulBuild/artifact/aggregation/final/buildInfo/reporeports/reports/verifydiroutput/unsigned8.txt

[2] https://hudson.eclipse.org/simrel/job/simrel.mars.runaggregator.CLEAN_BUILD/lastSuccessfulBuild/artifact/aggregation/final/buildInfo/reporeports/reports/layoutCheck.txt
Comment 4 Markus Tiede CLA 2015-06-01 03:54:39 EDT
The resolving of these issues has also been recommended on cross-project-issues dev mailing list.
Comment 6 Alexandra Schladebeck CLA 2015-06-02 07:54:00 EDT
We've discovered that this feature isn't currently being signed. We are using a combination of different tycho plugins to generate the feature - and the signing doesn't seem to work for this transiently created source feature jar. 

Markus, our release engineer, is looking into this in the hope that we can fix it for RC3. In case that doesn't work, what would you recommend as the next steps? Would it be possible to get an exception for it? We'd prefer to leave it in if possible.
Comment 7 Markus Tiede CLA 2015-06-02 08:11:21 EDT
I've found a pretty good hint on cbi-dev - see [1] - and will give it a try.

[1] http://dev.eclipse.org/mhonarc/lists/cbi-dev/msg00867.html
Comment 8 David Williams CLA 2015-06-02 08:20:44 EDT
I doubt this was intended to be assigned to me, was it? Perhaps add me to CC? 

It is not currently showing up as unsigned ... is that because you removed it? 

(Would be best to be present, and would be best to be signed ... so ... hope your releng can fix it). 

Let me know if you had a more specific question for me.
Comment 9 Markus Tiede CLA 2015-06-02 08:27:35 EDT
Thanks for the update David!

@DW: No, we haven't done anything so far (even not removed our artefact - see [1]) addressing this signing problems (for mars) and though: it's not listed there [anymore] (though I can confirm that the artefact we're contributing not signed). Maybe there is a problem with the report at the moment?

As bug 396445 also points out the (same) solution I'm currently giving it a try on master:

http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=cd7fca84136fc22448e9cf0e8673ea47c3e58f8e

And it's already part of Jubula nightly build #2455 - I'm pretty sure this will resolve it. As soon as I can confirm that I'll also apply it to our mars branch.

[1] http://download.eclipse.org/jubula/milestones/mars-rc2/features/org.eclipse.jubula.feature.api.core.source_3.1.0.201505270711.jar
Comment 11 David Williams CLA 2015-06-02 09:05:34 EDT
What's the exact name of the source feature that is (was) unsigned? 

I just want to investigate why latest reports do not report it.
Comment 12 Markus Tiede CLA 2015-06-02 09:14:37 EDT
@DW: Thanks for investigating this!

It's the artefact referenced as [1] in comment 9 and currently listed  at position 663. in the "Feature names report" - see [a]: org.eclipse.jubula.feature.api.core.source.feature.group   3.1.0.201505270711  
Jubula Functional Testing - API Core Developer Resources

[a] https://hudson.eclipse.org/simrel/job/simrel.mars.runaggregator.CLEAN_BUILD/lastSuccessfulBuild/artifact/aggregation/final/buildInfo/reporeports/reports/featureNames.html
Comment 13 Sebastian Struckmann CLA 2015-06-03 04:45:38 EDT
I can confirm that the jar is now signed.