Bug 462311 - Remove (or at least extract) Movida-specific code
Summary: Remove (or at least extract) Movida-specific code
Status: CLOSED FIXED
Alias: None
Product: Sirius
Classification: Modeling
Component: Core (show other bugs)
Version: 1.0.0M6   Edit
Hardware: All All
: P4 enhancement (vote)
Target Milestone: 6.0.0   Edit
Assignee: Pierre-Charles David CLA
QA Contact: Florian Barbin CLA
URL:
Whiteboard:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2015-03-17 04:23 EDT by Pierre-Charles David CLA
Modified: 2018-06-27 11:55 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre-Charles David CLA 2015-03-17 04:23:00 EDT
Movida was an experimental project which never reached a state where we could enable its features by default. As such, it is effectively dead weight.

From a quick test, it looks like this could get rid of at least 17k SLOC, mostly in these areas:
* the "contributions.ecore" metamodel and all its corresponding generated code.
* all the runtime code used to interpret the contributions definitions.
* the Movida static class, which served as a feature flag, leads to most of the places in the code with Movida-specific code branches that can be removed.
* the alternative ViewpointRegistry implementation, and the split between ViewpointRegistry and the default ViewpointRegistryImpl, which because less useful with a single implementation.
* the Viewpoint.{conflicts,reuses,customizes} references and associated generated code.
* DialectServices.refreshEffectiveRepresentationDescription() and other APIs (if any) which were introduced for the Movida use case.
* any other internal support code which was used only by the code being removed.
Comment 1 Eclipse Genie CLA 2018-01-19 05:55:14 EST
New Gerrit change created: https://git.eclipse.org/r/115686
Comment 3 Pierre-Charles David CLA 2018-02-08 04:03:38 EST
Fixed by c07b653ced6294685d7f570a80d50bddb0b915d5.

Note that this is a purely internal code change, which should have no visible effect except for the (documented) removal of some APIs where never actually used.
Comment 4 Laurent Redor CLA 2018-06-27 11:55:20 EDT
Available in Sirius 6.0.0, see https://wiki.eclipse.org/Sirius/6.0.0 for details