Bug 461838 - Resource#accept(IResourceProxyVisitor, int, int) should visit files in alphabetic order
Summary: Resource#accept(IResourceProxyVisitor, int, int) should visit files in alphab...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Resources (show other bugs)
Version: 4.5   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.5 M7   Edit
Assignee: Markus Keller CLA
QA Contact: Szymon Ptaszkiewicz CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 461861 463153
  Show dependency tree
 
Reported: 2015-03-10 11:29 EDT by Markus Keller CLA
Modified: 2015-04-02 10:32 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2015-03-10 11:29:48 EDT 
Resource#accept(IResourceProxyVisitor, int, int) should visit files in alphabetic order. 

ElementTreeIterator#iterate(IElementContentVisitor) and #doIteration(DataTreeNode, IElementContentVisitor) try to be smart and save a local variable by iterating backwards, but this violates KISS and basic client assumptions.

One effect is that file search in Eclipse reports elements in backwards order, which causes noise when elements are inserted at the top of the results view.
Comment 1 Eclipse Genie CLA 2015-03-10 11:33:53 EDT 
New Gerrit change created: https://git.eclipse.org/r/43586
Comment 3 Szymon Ptaszkiewicz CLA 2015-03-25 09:15:39 EDT 
Fixed in master. Thanks, Markus!
Comment 4 Jay Arthanareeswaran CLA 2015-03-30 01:24:00 EDT 
This is causing failures in some JDT Core tests, see bug 463153.
Comment 5 Szymon Ptaszkiewicz CLA 2015-04-02 10:32:31 EDT 
Verified in I20150331-0800.