Bug 453032 - Dark theme support in the HTML editor
Summary: Dark theme support in the HTML editor
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.html (show other bugs)
Version: 3.6.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6.3   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard: PMC_Approved
Keywords:
Depends on:
Blocks:
 
Reported: 2014-11-24 08:53 EST by Kaloyan Raev CLA
Modified: 2015-01-21 16:01 EST (History)
8 users (show)

See Also:
nsand.dev: pmc_approved? (david_williams)
nsand.dev: pmc_approved? (raghunathan.srinivasan)
nsand.dev: pmc_approved? (naci.dai)
nsand.dev: pmc_approved? (neil.hauge)
cbridgha: pmc_approved+
nsand.dev: pmc_approved? (kaloyan)
nsand.dev: pmc_approved? (ccc)

Attachments
patch (3.02 KB, patch)
2014-11-24 08:56 EST, Kaloyan Raev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kaloyan Raev CLA 2014-11-24 08:53:01 EST 
The wst.html plugins does not contribute a CSS with the syntax highlighting for the dark theme. Hence, the HTML editor does not look well and is hardly usable when the dark theme is active in Eclipse.
Comment 1 Kaloyan Raev CLA 2014-11-24 08:56:47 EST 
Created attachment 248866 [details]
patch

This contribution complies with http://www.eclipse.org/legal/CoO.php
Comment 2 Kaloyan Raev CLA 2014-11-24 09:02:02 EST 
Please consider this patch for the next maintenance release, i.e. Luna SR2.
Comment 3 Nick Sandonato CLA 2015-01-21 13:27:25 EST 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such.

It can be seen as a usability issue for users of the dark theme.

* Is there a work-around? If so, why do you believe the work-around is insufficient?

The user can define his/her own color scheme, but it is inefficient to do so. In addition, this is not done right off the bat, so the user just sees dark colors on a dark background to start.

* How has the fix been tested? Is there a test case attached to the bugzilla record? 

Ad hoc testing.

* Has a JUnit Test been added?

No.

* Give a brief technical overview. Who has reviewed this fix?

This patch implements the dark theme for the org.eclipse.e4.ui.css.swt.theme extension point. I have reviewed the fix.

* What is the risk associated with this fix?

Low.