Bug 443473 - Migrate tests to JUnit4
Summary: Migrate tests to JUnit4
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: PHP Core CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-07 20:51 EDT by Dawid Pakula CLA
Modified: 2020-05-14 11:25 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawid Pakula CLA 2014-09-07 20:51:35 EDT 
As in subject. Clean code, easier to extend.
Comment 1 Dawid Pakula CLA 2014-11-29 04:35:12 EST 
Patch proposal: https://git.eclipse.org/r/#/c/37315/

Current state:
 * API: Two special JUnit4 runners for PDTTTests.
 * All tests in core plugin except FileNetworkTests are converted
 * All tests from ui and formatter plugins are converter

Not converted
 * FileNetworkTests - a lot of boilerplate code for only 6 tests. Any adopters use these classes ?
 * Performance tests - they are disabled by default so they are not important now. 

Problems:
 * Around 100 additional tests after conversion. I'm not sure how it can be possible ;)
 * Due conversion all *Test classes have different API. But is still possible to use tools for JUnit3 (see performance tests)
Comment 2 Dawid Pakula CLA 2014-11-29 05:01:06 EST 
I forgot about another TestSuite.

CodeAssistProjectTests.class is disabled (6 pdtt files). Someone remember why?
Comment 4 Michal Niewrzal CLA 2015-01-16 04:43:23 EST 
Closing.