443468 – File saving is freezing PDT when Outline view is active

Bug 443468 - File saving is freezing PDT when Outline view is active

Summary: File saving is freezing PDT when Outline view is active

Status:	CLOSED FIXED

Alias:	None

Product:	z_Archived
Classification:	Eclipse Foundation
Component:	PDT (show other bugs)
Version:	unspecified
Hardware:	PC All

Importance:	P3 major (vote)
Target Milestone:	---
Assignee:	PHP UI
QA Contact:

URL:
Whiteboard:
Keywords:	performance

Depends on:
Blocks:

Reported:	2014-09-07 14:53 EDT by Michal Niewrzal
Modified:	2020-05-14 11:49 EDT (History)
CC List:	3 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Example file (43.81 KB, text/plain) 2014-09-07 14:53 EDT, Michal Niewrzal	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michal Niewrzal

2014-09-07 14:53:53 EDT

Created attachment 246800 [details]
Example file

When php file has many members (e.g. 2000 methods in class) then every save is updating whole Outline view viewer. This freezes PDT for a few seconds.

Comment 1 Michal Niewrzal

2014-09-07 17:35:16 EDT

Patch proposal: https://git.eclipse.org/r/#/c/33010/

Comment 2 Dawid Pakula

2014-09-11 08:46:59 EDT

Merged: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=8f56a7caee3fda17e509b2c32cd50f3a5c87bcfe

Thank You :D

Comment 3 Michal Niewrzal

2014-09-14 07:36:11 EDT

I found another case where saving file is freezing PDT. When one of the opened files is under GIT control then GitLightweightDecorator is triggering LabelProviderChangedEvent after every save. This is causing refresh of all Outline viewers. If 2-3 files like from example are opened also then PDT is freezing for few seconds.

Comment 4 Eclipse Genie

2015-06-01 16:24:24 EDT

New Gerrit change created: https://git.eclipse.org/r/49135

Comment 5 Michal Niewrzal

2015-06-01 16:26:56 EDT

Exact steps to reproduce:
* Use project under GIT control
* Copy into it 4-5 copies of example file and open all 
* Be sure Outline is opened
* Make any change in one of files and save it
* PDT will freeze for a moment

Comment 6 Eclipse Genie

2015-06-02 15:34:43 EDT

Gerrit change https://git.eclipse.org/r/49135 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=417e4d387f80f2b78877f338222fab37bffc7f96

Comment 7 Michal Niewrzal

2015-06-02 15:35:45 EDT

I hope this is the last patch for this issue ;) Fixed.

Comment 8 Eclipse Genie

2015-06-03 09:11:49 EDT

New Gerrit change created: https://git.eclipse.org/r/49360

Comment 9 Michal Niewrzal

2015-06-03 09:13:01 EDT

Reopened because bug 469271.

Comment 10 Eclipse Genie

2015-06-03 09:43:19 EDT

Gerrit change https://git.eclipse.org/r/49360 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=b6cafb87ca8c31676e18a727b0541a06aac8cb91

Comment 11 Eclipse Genie

2015-06-08 12:23:34 EDT

New Gerrit change created: https://git.eclipse.org/r/49685

Comment 12 Eclipse Genie

2015-06-09 06:59:46 EDT

Gerrit change https://git.eclipse.org/r/49685 was merged to [master].
Commit: http://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=f6f7bc2ddbf32be3dcf74a584ec6f2d18633936a

Comment 13 Michal Niewrzal

2015-06-09 07:00:01 EDT

Fixed.

Comment 14 Sylvia Tancheva

2015-06-18 10:50:18 EDT

Looks OK now. Did not get stuck. Closing