Bug 441496 - Deprecated members styling doesn't work for traits static methods
Summary: Deprecated members styling doesn't work for traits static methods
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-11 06:44 EDT by Michal Niewrzal CLA
Modified: 2020-05-14 11:39 EDT (History)
2 users (show)

See Also:

Attachments
Example (27.40 KB, image/png)
2014-08-11 06:44 EDT, Michal Niewrzal CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Niewrzal CLA 2014-08-11 06:44:44 EDT 
Created attachment 245876 [details]
Example

To reproduce:

* Enable styling for deprecated members
* Paste code
<?php
abstract class AC {
	/**
	 * @deprecated
	 */
	static function f() {
	}
}
trait T {
	/**
	 * @deprecated
	 */
	static function f() {
	}
}

AC::f ();
T::f ();
Comment 1 Dawid Pakula CLA 2014-08-11 07:02:35 EDT 
Probably doesn't work because TI also doesn't work:

trait T {
  static function f() {
    return new DateTime();
  }
}

T::f()-> // empty after ctr+space
Comment 2 Michal Niewrzal CLA 2014-08-21 16:44:47 EDT 
It looks that problem with styling is separated from CA problem. I'll open separate bug for this CA issue (CA doesn't work in general for static traits methods). 

Proposed patch should fix styling for deprecated method and I found also problem with styling for static invocation class name. Full example:

<?php
/**
 *
 *@deprecated
 */
class AC {
	static function fxxx() {
	}
}
trait T {
	
	/**
	 *
	 * @deprecated
	 *
	 */
	public static function f() {
		return new DateTime ();
	}
}

T::f ();
AC::fxxx ();


Patch proposal: https://git.eclipse.org/r/#/c/32106/
Comment 4 Sylvia Tancheva CLA 2015-05-21 08:46:04 EDT 
Verified. Closing