Bug 441365 - Highlighting preferences for breakpoints do not affect the PHP editor
Summary: Highlighting preferences for breakpoints do not affect the PHP editor
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: PHP Debug CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-07 11:36 EDT by Michal Niewrzal CLA
Modified: 2020-05-14 11:24 EDT (History)
2 users (show)

See Also:


Attachments
How it should looks (JDT example) (24.25 KB, image/png)
2014-08-07 11:36 EDT, Michal Niewrzal CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Niewrzal CLA 2014-08-07 11:36:17 EDT
Created attachment 245808 [details]
How it should looks (JDT example)

Steps to reproduce:
* Open Window > Preferences
* Go to General > Editors > Text Editors > Annotations
* Select Breakpoints in the list
* Select the Show in > Text as checkbox
* Click OK

Expected:
The text of breakpoints in the PHP editors should be highlighted with the specified color.

Actual:
No change in breakpoints highlighting in the PHP editor.
The issue is only observed in the PHP editor, but not for other editors like the JavaScript editor.

Most probably, the issue is caused by the lack of CHAR_START and CHAR_END attributes for the PHP breakpoint marker, so the platform fails to determine the exact text to be highlighted.
Comment 1 Michal Niewrzal CLA 2014-08-07 12:01:39 EDT
Patch: https://git.eclipse.org/r/#/c/31213/
Comment 2 Kaloyan Raev CLA 2014-08-07 17:18:54 EDT
Great! Thanks for the patch!
Merged: https://git.eclipse.org/c/pdt/org.eclipse.pdt.git/commit/?id=c1c6adc2dec960c5dbc26617a13091d512c71a3c
Comment 3 Sylvia Tancheva CLA 2015-05-27 10:36:47 EDT
Looks OK now. Closing