Community
Participate
Working Groups
Created attachment 240454 [details] The patch The no-run option argument can have only one of the following values: "caa" The test executes up to connect to AUT Agent step (inclusive) "cdb" The test executes up to connect to database step (inclusive) "lp" The test executes up to project load step (inclusive) "cc" The test executes up to check test completeness step (inclusive) "sa" The test executes up to start AUT step (inclusive) "pte" The test executes up to prepare test execution step (inclusive) "ca" The test executes up to connect to AUT step (inclusive) "rpv" The test executes up to resolve predefined variables step (inclusive) "bt" The test executes up to build test execution tree step (inclusive) The no-run option argument is optional, with no argument the test executes up to check test completeness step (inclusive). The patch is attached.
Created attachment 242326 [details] The patch for norun extention I´ve reattached the file because the previous one was too old to apply and to review it.
Created attachment 242327 [details] The patch for norun extention
thanks for the contribution. In the IOConstants and NetUtil you have added methods and information for the no-run option, this is not a good place for these methods since the no run has nothing to do with Network(NetUtil) and also i have my doubt if the IOConstants since this is for input output constans. Please change this to either own classes or appropriate other classes. Simplify the use of your NetUtil.noRunExecutionIsOverCheck() in the points where the test execution ends. Since if you call it you are also calling endTestExecution it is better to get rid of double code in using another method for it. Maybe it is also useful to have the target of the noRun option stored into a singleton so you can reuse this in the noRunExecutionIsOverCheck() in a easy way and you must not give over this as a parameter each time. This is useful since the noRun option does not change during runtime. Also you are violating our Checkstyle in the executeJob method in the ExecutionController class. The method is to long.
Created attachment 242502 [details] Changed patch Thanks for valuable feedback! I´ve moved constants from IOConstants to newly created TestexecConstants class (org.eclipse.jubula.tools/src/org/eclipse/jubula/tools/constants/TestexecConstants.java) because we did not have any other corresponding class. Also I´ve moved isNoRunModeValid method from NetUtils to the JobConfiguration class because it is used only within this class and removed noRunExecutionIsOverCheck() from NetUtils. As far as I can see, currently other testexec arguments are also passed as parameters to startTestJob and startTestSuite methods and they are not stored into a singleton though they also do not change during the runtime. So I´ve just simplified the noRunExecutionIsOverCheck() and have not created a singlton.
Created attachment 242536 [details] patch with merged changes after other testexec patch apply I´ve merged changes after other testexec patch apply. This patch is applicable
Thanks! I added it with: http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=b2e8b2ce728d40d692ab1ae58d63b9cd4fcbe7e0
Created attachment 242703 [details] Patch for handling NPE caused by changes in no-run option Change in no run option caused NPE during the test execution via the ITE. The attached patch handle this problem
The fix looks good. I added it with: http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=da13f0d4e28ee53f26c8c30112f17977eecfe109
This is not fixed (see task JUB-238)
Patch has been reapplied [1] with some small changes after temporary revert. Now, this should finally work as expected. [1] http://git.eclipse.org/c/jubula/org.eclipse.jubula.core.git/commit/?id=931ab65dbe6ab340bd77dcae2b06ce7a315a3562
This ticket is blocked by 436061
All blocking tickets have been fixed, Jira task is set to done.
Closed due to comment 12.
