Bug 429157 - memory-changed event may not trigger an update for the proper number of octets
Summary: memory-changed event may not trigger an update for the proper number of octets
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.4.0   Edit
Assignee: Alvaro Sanchez-Leon CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-26 09:59 EST by Alvaro Sanchez-Leon CLA
Modified: 2014-02-26 10:49 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2014-02-26 09:59:00 EST 
The new event "memory-changed" introduced from GDB 7.6 may is not handled properly in the implementation for DSF-GDB. 

 The current code divides the length by 8 and adds 1 to resolve the number of addresses. For system with addressable size of 1 octet this would not work for lengths greater than one.  

In the other hand the event is expected to be received with the number of addressable units affected, so there is no need to make an adjustment.
Comment 1 Marc Khouzam CLA 2014-02-26 10:49:20 EST 
Fix was posted here:
https://git.eclipse.org/r/#/c/22573/

Thanks for the fixed Alvaro, I've committed to master.

I've also committed a fix to improve the tests so they could detect this bug.  This new version fails before the fix and passes after it.

http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=0b2adb52230d9a60b424c70ad01294019be1067d