Bug 419017 - Breakpoints view details pane
Summary: Breakpoints view details pane
Status: ASSIGNED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Jonah Graham CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-09 07:26 EDT by Alvaro Sanchez-Leon CLA
Modified: 2020-09-04 15:17 EDT (History)
4 users (show)

See Also:


Attachments
screen shots different types of detail panes per break point type (333.70 KB, application/vnd.oasis.opendocument.text)
2013-11-05 08:03 EST, Alvaro Sanchez-Leon CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2013-10-09 07:26:58 EDT
It is desirable to add a detail pane to the breakpoints view, 
see discussion at Bug 360588 comment 3.

A proposal will follow to receive comments related to the contents in this detail pane.
Comment 1 Alvaro Sanchez-Leon CLA 2013-11-05 08:03:49 EST
Created attachment 237196 [details]
screen shots different types of detail panes per break point type

A draft implementation for the break point detail pane is now available at 
 
https://git.eclipse.org/r/#/c/17181/

you can also see the relevant screen shots attached to this bug in a "Libreoffice Writter" document.

The implementation is based on a Mikhail's prototype and was modified to re-use the "common" property page currently available for the break point property dialogue, therefore this implementation is short but dependent on existing page layouts, with the benefit of re-using the saving and validation mechanisms.
  I.e. Modifying the page layout will also implicate changes to the layout in the property dialogue.

Comments and questions are very welcome and expected !
Comment 2 Nobody - feel free to take it CLA 2013-11-20 16:35:26 EST
I am not sure it's good idea to re-use the breakpoint's property page as a content of the detail pane. First of all it doesn't fit well in the view and at least needs scroll bars. Having "Condition" and "Ignore count" in the pane is justifiable but I don't see why we need to duplicate the "Enable/disable" option and add the ability of changing the line number.
My original patch was intended to display additional context specific information that was hidden from users, like hit counts, pending status and error messages. I still find it more important. Of course, if we modify the breakpoints view to present the corresponding target breakpoints along with the platform breakpoints the detail pane's content of the latter would be similar to what Alvaro is proposing while the target breakpoint's content would include the target related info.
Comment 3 Alvaro Sanchez-Leon CLA 2013-11-22 11:55:31 EST
(In reply to Mikhail Khodjaiants from comment #2)
> I am not sure it's good idea to re-use the breakpoint's property page as a
> content of the detail pane. First of all it doesn't fit well in the view and
> at least needs scroll bars. Having "Condition" and "Ignore count" in the
> pane is justifiable but I don't see why we need to duplicate the
> "Enable/disable" option and add the ability of changing the line number.
> My original patch was intended to display additional context specific
> information that was hidden from users, like hit counts, pending status and
> error messages. I still find it more important. Of course, if we modify the
> breakpoints view to present the corresponding target breakpoints along with
> the platform breakpoints the detail pane's content of the latter would be
> similar to what Alvaro is proposing while the target breakpoint's content
> would include the target related info.

Thanks for the feedback Mikhail, 
I see the point on avoiding redundant information,

It would be grate if you could provide a small list of the attributes you think are more important to display, were you considering any values that require writing ?