Bug 418176 - Register view does not refresh register names per process
Summary: Register view does not refresh register names per process
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 8.1.0   Edit
Hardware: All Linux
: P3 normal (vote)
Target Milestone: 8.3.0   Edit
Assignee: Alvaro Sanchez-Leon CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-27 08:18 EDT by Alvaro Sanchez-Leon CLA
Modified: 2013-09-29 22:40 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alvaro Sanchez-Leon CLA 2013-09-27 08:18:24 EDT 
When debugging multiple processes on the same session, the registers view is expected to reflect the register names and values related to the specific process as these processes could be compiled for 64-bits or 32-bits, etc.. and therefore contain a different set of registers.

The current logic fails to retrieve the corresponding list of register names when switching the selection from the frame of one process to a frame in the another process, i.e. keeps the list of register names associated with the process which is selected first.
Comment 1 Alvaro Sanchez-Leon CLA 2013-09-27 09:54:26 EDT 
The following change has been pushed for review:
https://git.eclipse.org/r/#/c/16837/

In summary: 
A single instance of Register group was being provided by MIRegisters.java, regardless of the calling container. Method getRegisterGroups
Comment 2 Marc Khouzam CLA 2013-09-27 10:12:55 EDT 
(In reply to Alvaro Sanchez-Leon from comment #1)
> The following change has been pushed for review:
> https://git.eclipse.org/r/#/c/16837/

Thanks Alvaro.  Can you rebase your change and push again?  It conflicts with the commit of bug 323552 which just happened.
Comment 3 Alvaro Sanchez-Leon CLA 2013-09-27 12:49:12 EDT 
> Thanks Alvaro.  Can you rebase your change and push again?  It conflicts
> with the commit of bug 323552 which just happened.

I have just submitted patch set 2, 
Thanks Marc
Comment 4 Marc Khouzam CLA 2013-09-29 22:40:05 EDT 
Looks good.  Committed.  Thanks!