417895 – Disassembly view formatting to use tab instead of space between opcode and operands (DSF)

Bug 417895 - Disassembly view formatting to use tab instead of space between opcode and operands (DSF)

Summary: Disassembly view formatting to use tab instead of space between opcode and op...

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug-dsf-gdb (show other bugs)
Version:	8.7.0
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	8.8.0
Assignee:	Jon Beniston
QA Contact:	Marc Khouzam

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2013-09-24 05:56 EDT by Jon Beniston
Modified:	2015-08-25 15:01 EDT (History)
CC List:	2 users (show)

See Also:	Gerrit Change Git Commit Gerrit Change Git Commit

Attachments
Patch to use tab instead of space (656 bytes, text/plain) 2013-09-24 05:56 EDT, Jon Beniston	marc.khouzam: iplog-	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jon Beniston

2013-09-24 05:56:07 EDT

Created attachment 235743 [details]
Patch to use tab instead of space

The disassembly view is not very clear as it uses a space between opcode and operands, rather than a tab (so the operands are not aligned).

The attached patch changes that, resulting in a much clearer disassembly view.

Note that bug 395557 applies to CDI, this patch is for DSF.

Comment 1 Marc Khouzam

2015-06-25 10:21:28 EDT

Hi Jon,

thanks for refreshing this bug, it reminds us that someone does care about it.  Can you please submit your patch using Gerrit, we can no longer accept patches coming in from bugzilla.

https://wiki.eclipse.org/CDT/git#Using_Gerrit_for_CDT

Comment 2 Eclipse Genie

2015-08-20 09:07:38 EDT

New Gerrit change created: https://git.eclipse.org/r/54225

Comment 3 Eclipse Genie

2015-08-25 09:11:19 EDT

Gerrit change https://git.eclipse.org/r/54225 was merged to [master].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=708d6a6318c0c8c787792744b2826396c4b1a710

Comment 4 Eclipse Genie

2015-08-25 09:12:34 EDT

New Gerrit change created: https://git.eclipse.org/r/54481

Comment 5 Eclipse Genie

2015-08-25 09:12:46 EDT

Gerrit change https://git.eclipse.org/r/54481 was merged to [cdt_8_8].
Commit: http://git.eclipse.org/c/cdt/org.eclipse.cdt.git/commit/?id=086de101df5a5abfada8cd037f3afd0d7e2fd89d

Comment 6 Marc Khouzam

2015-08-25 09:13:40 EDT

Committed to master and 8_8

Thanks Jon for not giving up on this.

Comment 7 Marc Khouzam

2015-08-25 15:01:30 EDT

I've put a note in the N&N about this change:
https://wiki.eclipse.org/CDT/User/NewIn88#More_readable_Disassembly_view