Bug 414519 - [Memory View] user specified start address is not honored
Summary: [Memory View] user specified start address is not honored
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug (show other bugs)
Version: 8.2.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 8.4.0   Edit
Assignee: Ling Wang CLA
QA Contact: Doug Schaefer CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-06 13:28 EDT by Ling Wang CLA
Modified: 2014-02-28 15:38 EST (History)
4 users (show)

See Also:

Attachments
proposed fix (1.63 KB, patch)
2013-08-06 13:40 EDT, Ling Wang CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ling Wang CLA 2013-08-06 13:28:14 EDT 
I saw this in Silicon Labs Studio, a DSF and EDC based debugger. 
Debug on a device that supports memory spaces. Then add a new Memory Monitor in Memory View. In the dialog, select a memory space, and specify start address (e.g. 0x30) that's different from start address of the memory space (which is usually 0x0). Click OK. The memory view shows the content starting from address 0x0 instead of from 0x30.
Comment 1 Ling Wang CLA 2013-08-06 13:40:26 EDT 
Created attachment 234127 [details]
proposed fix
Comment 2 Marc Khouzam CLA 2013-08-06 13:50:17 EDT 
Hi Ling.  Please sign your CLA:
http://dev.eclipse.org/mhonarc/lists/cdt-dev/msg26105.html

and push the patch to Gerrit for review:
http://wiki.eclipse.org/CDT/git#Using_Gerrit_for_CDT

Thanks!
Comment 3 Ling Wang CLA 2013-08-23 11:26:09 EDT 
Patch posted to gerrit.
Comment 4 Marc Khouzam CLA 2014-02-20 14:37:24 EST 
The patch is here:
https://git.eclipse.org/r/#/c/15214/
Comment 5 Alvaro Sanchez-Leon CLA 2014-02-28 06:55:44 EST 
I have posted my comments in the Gerrit change.

http://wiki.eclipse.org/CDT/git#Using_Gerrit_for_CDT

I am not a committer for CDT but I have contributed several changes in the memory code recently, so I thought I could help by reviewing this change.
Comment 6 Marc Khouzam CLA 2014-02-28 15:38:34 EST 
Thanks Ling for the fix and Alvaro for the review.
It also looks good to me (although I would have missed the other Rendering.java class if it wasn't for Alvaro's review).

I committed to master from Gerrit.