Community
Participate
Working Groups
In the current implementation, the Multicore Visualizer has one filter level available. If a filter is applied, and the user starts or switches to a different debug session, the same filter is applied to the new debug session. It would be preferable that a different filter be available for each debug session, and that any active filter (or absence of filter) be remembered and automatically restored upon re-selection of a session.
Hi, Here is a patch for this bug: https://git.eclipse.org/r/#/c/12841/1 Here are the main changes : - Created a new class to manage the filters: MulticoreVisualizerCanvasFilterManager . It saves the filters and provides the canvas with the one corresponding to a given model/session, creating the filter the first time it's requested. - MulticoreVisualizerCanvas: replaced the use of a MulticoreVisualizerCanvasFilter object by a MulticoreVisualizerCanvasFilterManager object. A default (empty) filter is created the first time a model/session is displayed in the visualizer, showing a non-filtered view of the model. As filters are being applied or cleared by the user, the corresponding filter is updated. - VisualizerModel: Added a field to save the DSF sessionId plus getter. This makes it possible for the canvas to request / setup the filter for a given session. Regards, Marc
w/r to the patch submitted in this bug, I declare the following: 1) that I am authorized to submit this code change 2) that the code is 100% my own work Marc Dumais
Since he had reviewed the original filter feature, I have added Marc-Andre on the review of this patch. Bill, if you have time you can still review this, but if not I think Marc-Andre can merge it.
I took a quick look through the code; apart from a couple variables that need a private/protected declaration this looks okay to me. This is mostly internal, functional behavior, rather than changes to the UI appearance, so Marc-Andre can merge it.
Merged into master.
