Community
Participate
Working Groups
The MulticoreVisualizer logic seems to rely on disposeVisualizer() being called when the visualizer view is disposed-of, to properly dispose of its objects. It doesnt seem to be. to reproduce: Set a breakpoint in MulticoreVisualizer:disposeVisualizer() and close the visualizer view. The breakpoint does not seem to hit. The problem seems to be in VisualizerViewer ; the dispose() method is apparently never called upon closing the Visualizer view. That seemed strange, so we googled and found the following post, that seems to indicate that we would need to use a "DisposeListener" instead of relying on dispose() being called: http://www.eclipse.org/forums/index.php/t/351342/
Hi! I now understand a bit more what was happening, I think. VisualizerViewer is overriding the dispose() method of Widget, probably expecting that its own version of it would be called when the view is disposed. But Widget does not recursively call the dispose() of its descendents, so the "cleanup chain" was broken at that level. Replacing the overridden dispose() by a disposeListener fixed that. Then from there there were a few other little things that needed fixing for the disposal of the view and its objects to happen harmoniously. While I was there, I thought it would be a good thing to replace the overridden instances of dispose(), of Widget descendants, by a disposeListener (for classes MulticoreVisualizerCanvas, GraphicCanvas and BufferedCanvas). That was not strictly necessary but it removes the need for each derived class level to call its super.dispose() and also it can prevent a sequence problem : for things to work correctly, each level of descendant needs to do its own local cleanup before calling "super.dispose()", else there can be exceptions when trying to dispose of listeners and such, when the disposal happens after the call of Widget.dispose(). An example of this was happening in the dispose() of BufferedCanvas. Hopefully all of this makes sense :) Here is the proposed patch: https://git.eclipse.org/r/#/c/10113/ Thanks, Marc P.S. BTW the following article was very helpful to help me understand how the Widget dispose() should work: http://www.eclipse.org/articles/swt-design-2/swt-design-2.html
w/r to the patch submitted in this bug, I declare the following: 1) that I am authorized to submit this code change 2) that the code is 100% my own work Marc Dumais
Thanks Bill for the review and merging this into master. I'll let you close the bug if you think it's resolved. How about also doing this fix in the 8.1 branch? Thanks, Marc
Fix reviewed and merged to master.
(In reply to comment #3) > How about also doing this fix in the 8.1 branch? That would have been good, but we're on the last day for 8.1.2 and I don't think it is worth the risk to put in a late fix like that. So, let's keep it in master only.
