Bug 396293 - [Visualizer] right side cpu_margin not taken into account when deciding if a new line of cores is needed
Summary: [Visualizer] right side cpu_margin not taken into account when deciding if a ...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 8.2   Edit
Assignee: William Swanson CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-11 11:10 EST by Marc Dumais CLA
Modified: 2013-02-21 16:17 EST (History)
3 users (show)

See Also:


Attachments
screen capture to illustrate issue (3.32 KB, image/png)
2012-12-11 11:10 EST, Marc Dumais CLA
no flags Details
Same screen capture, with proposed fix in place (3.36 KB, image/png)
2012-12-11 11:28 EST, Marc Dumais CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Dumais CLA 2012-12-11 11:10:44 EST
Created attachment 224575 [details]
screen capture to illustrate issue

This refers-to MulticoreVisualizerCanvas.java, recache() method: 

This is a subtle issue.  It's a corner-case that only became apparent when we tried increasing the value of core_margin (for example set it to 40 to make the problem easier to see).  

As it is, the algorithm takes into account the left cpu_margin when placing cores in a CPU, but doesn't take into account the right cpu_margin into it's calculation.  This can result in a core being placed within the right cpu margin, causing a dissymetry in the display.

I attach a screen capture to illustrate this.

Regards,

Marc
Comment 1 Marc Dumais CLA 2012-12-11 11:28:19 EST
Here is a proposed patch for this issue:

About the following patch, I declare the following:

1) that I am authorized to submit this code change
2) that the code is 100% my own work

https://git.eclipse.org/r/9158
Comment 2 Marc Dumais CLA 2012-12-11 11:28:56 EST
Created attachment 224581 [details]
Same screen capture, with proposed fix in place
Comment 3 William Swanson CLA 2013-02-19 15:01:41 EST
Change has been committed, setting to resolved/fixed.