Bug 396200 - [Visualizer] m_recache is never reset to false
Summary: [Visualizer] m_recache is never reset to false
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: Next   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: 8.2   Edit
Assignee: William Swanson CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-12-10 10:30 EST by Marc Dumais CLA
Modified: 2013-02-21 16:18 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Dumais CLA 2012-12-10 10:30:54 EST 
This happens in MulticoreVisualizerCanvas.java in method recache().   

The first thing that happens in method recache(), is a check to see if m_recache is set to true; if not, the method returns immediately.   However, this check seems to be useless at the moment, since m_recache is never reset to false.  

So the check could either be removed or m_recache could be set to false after the check is done, so it does what was probably intended.

Note: this is minor since variables m_recacheState and m_recacheSizes still ensure that nothing happens unless requestRecache() was called.
Comment 1 Marc Dumais CLA 2012-12-10 10:35:13 EST 
Proposed patch:

https://git.eclipse.org/r/9142
Comment 2 Marc Dumais CLA 2012-12-10 14:59:26 EST 
w/r to the patch submitted in this bug, I declare the following:

1) that I am authorized to submit this code change
2) that the code is 100% my own work
Comment 3 William Swanson CLA 2013-02-19 15:00:43 EST 
Change has been committed, setting to resolved/fixed.