336961 – [tracepoints] selectTraceRecord() should not update the UI

Bug 336961 - [tracepoints] selectTraceRecord() should not update the UI

Summary: [tracepoints] selectTraceRecord() should not update the UI

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-debug-dsf-gdb (show other bugs)
Version:	8.0
Hardware:	PC Linux

Importance:	P3 normal (vote)
Target Milestone:	8.0
Assignee:	Marc Khouzam
QA Contact:	Marc Khouzam

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-11 11:21 EST by Marc Dumais
Modified:	2014-01-29 22:47 EST (History)
CC List:	3 users (show)

See Also:

Flags:	marc.khouzam: review? (fchouinard)

Attachments
proposed patch (11.29 KB, patch) 2011-02-11 11:26 EST, Marc Dumais	marc.khouzam: iplog+	Details \| Diff
Updated patch to match HEAD (8.40 KB, patch) 2011-03-04 11:21 EST, Francois Chouinard	cdtdoug: iplog-	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Marc Dumais

2011-02-11 11:21:02 EST

Build Identifier: M20100909-0800

We heavily use interface selectTraceRecord to fetch record information.   Since we don't do it from a user interaction, this call should not update the UI automatically.  

Reproducible: Always

Comment 1 Marc Dumais

2011-02-11 11:26:08 EST

Created attachment 188792 [details]
proposed patch

Comment 2 Francois Chouinard

2011-03-04 11:21:23 EST

Created attachment 190405 [details]
Updated patch to match HEAD

Same patch with minor adaptations to match HEAD.

Comment 3 Marc Khouzam

2011-04-25 09:55:28 EDT

Committed to HEAD.

Francois, when you have time, can you review?

Comment 4 CDT Genie

2011-04-25 10:23:13 EDT

*** cdt cvs genie on behalf of mkhouzam ***
Bug 336961: selectTraceRecord() should not update the UI because it can be used for background activities.

[*] GdbSelectPrevTraceRecordCommand.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbSelectPrevTraceRecordCommand.java?root=Tools_Project&r1=1.1&r2=1.2
[*] GdbSelectNextTraceRecordCommand.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/src/org/eclipse/cdt/dsf/gdb/internal/ui/commands/GdbSelectNextTraceRecordCommand.java?root=Tools_Project&r1=1.1&r2=1.2

[*] GDBTraceControl_7_2.java 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/gdb/service/GDBTraceControl_7_2.java?root=Tools_Project&r1=1.4&r2=1.5