Community
Participate
Working Groups
Build Identifier: I20100603-1500 While adding functionality to DSF-GDB, we have a case where a lot more than 20 OOB records would be needed. Specifically, the GDB response to a "tdump" command is spread over hundreds of OOB records. The suggested fix is to add a check when discarding OOB records and not discard any if a command is running. When a command is not running, the current default of keeping the last 20 records seems reasonable. Reproducible: Always Steps to Reproduce: N/A ; the code needed to reproduce is not yet integrated.
Bug 302927 introduced this limitation. Interestingly, for the CDI fix, we do check if a command is currently in the queue and don't discard in that case. We need to do the same for DSF-GDB. This problem could occur for any CLI command that has an answer of more than 20 lines.
Created attachment 183465 [details] proposed patch The patch adds a check to see if a command is currently running. If so, no limit is put on the number of OOB records being kept. Else the previous limit of 20 is still in effect.
(In reply to comment #2) > Created an attachment (id=183465) [details] > proposed patch > > The patch adds a check to see if a command is currently running. If so, no > limit is put on the number of OOB records being kept. Else the previous limit > of 20 is still in effect. Thanks for the contribution. Committed to HEAD.
Committed to 7_0 also.
*** cdt cvs genie on behalf of mkhouzam *** Bug 330608: Only discard OOB records if we are not waiting for an answer. This is to keep all output of CLI commands. [*] AbstractMIControl.java 1.15 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/AbstractMIControl.java?root=Tools_Project&r1=1.14&r2=1.15 [*] AbstractMIControl.java 1.14.2.1 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/AbstractMIControl.java?root=Tools_Project&r1=1.14&r2=1.14.2.1