NEW DATE! Bugzilla will undergo maintenance 2024-03-28 18h00 CET. Bugzilla will be placed in read-only mode at that time.

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 257806 - Comments discarded
Summary: Comments discarded
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 1.1.0 M1   Edit
Assignee: Florian Thienel CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2008-12-06 10:32 EST by David Carver CLA
Modified: 2013-01-26 17:36 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Carver CLA 2008-12-06 10:32:59 EST
VEX currently discards any comments in the XML document.   It needs to preserve these comments so that they are rewritten back to the XML file when saving.
Comment 1 Florian Thienel CLA 2011-11-09 17:37:51 EST
Moved to Mylyn Docs Vex.
Comment 2 Florian Thienel CLA 2012-03-04 05:33:14 EST
With http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.docs.vex.git/commit/?id=8dec4d884b9a9276133b8eb92eb28ce6dd5328e5 Vex can handle comments within the root element now. If you have comments before or after the root element, those are still discarded.

Support for "outer comments" requires a major refactoring of the DOM since Document can have only one child (namely its RootElement) at the moment. I would suggest to postpone this major refactoring until we have released 1.0.
Comment 3 Florian Thienel CLA 2012-03-21 15:47:21 EDT
I added the markers <!-- and --> as static text before resp. after comments.
Comment 4 Florian Thienel CLA 2013-01-08 05:18:26 EST
The "big scary refactoring" has taken place and I was finally able to add also support for comments outside the root element.

(f57b809)
Comment 5 Florian Thienel CLA 2013-01-26 17:36:07 EST
Released 1.1.0 M1