Bug 235747 - [registers][cdi] Allow user to edit the register groups.
Summary: [registers][cdi] Allow user to edit the register groups.
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-debug-dsf-gdb (show other bugs)
Version: 0 DD 1.0   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 8.6.0   Edit
Assignee: Alvaro Sanchez-Leon CLA
QA Contact: Marc Khouzam CLA
URL:
Whiteboard:
Keywords:
Depends on: 346301
Blocks: 449843 449104
  Show dependency tree
 
Reported: 2008-06-04 23:42 EDT by Pawel Piech CLA
Modified: 2014-12-09 17:51 EST (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Piech CLA 2008-06-04 23:42:18 EDT
CDI-GDB allows users edit the content of the register groups.  This is not necessarily very practical but for feature equivalence, DSF-GDB should implement it.
Comment 1 Marc Khouzam CLA 2012-07-04 13:31:21 EDT
My users like the idea of being able to create manual register groups to better control what registers are being looked at.

As an improvement to the register-grouping dialog used by CDI, it was suggested to use in-view multi-selection.  That way, the user would select all registers that should be in a group, and then right-click -> "Add to new group"  To make the UI simple, such a new group would be given a default name.  It would be nice if the user could modify that name in-line in the view, but if not, the CDI "Edit register group" UI could be enough.

Just like CDI, we feel that group persistence should be per launch (unlike the Expressions view, which has its persistence per workspace, although I'm not sure why).

If I don't get any comments against it, I'll work on a multi-select solution and post the result for review.
Comment 2 Alvaro Sanchez-Leon CLA 2013-06-21 11:42:05 EDT
The first draft of this functionality is ready for review: 
see https://git.eclipse.org/r/#/c/13980/

Manual test has been done along the implementation,
Junit testing is still pending for a later patch set.
Comment 3 Marc Khouzam CLA 2014-08-04 12:50:01 EDT
I've pushed a patch based on Alvaro's feature that moves the register group actions to the command framework:
  https://git.eclipse.org/r/30984
Comment 4 Marc Khouzam CLA 2014-08-07 13:42:44 EDT
(In reply to Marc Khouzam from comment #3)
> I've pushed a patch based on Alvaro's feature that moves the register group
> actions to the command framework:
>   https://git.eclipse.org/r/30984

We decided to merge this second review into Alvaro's original one, so that comments can be addressed on top of the change to the command framework but yet, in the same review as the comments were input.  So all changes are now part of:

  https://git.eclipse.org/r/#/c/13980/
Comment 5 Alvaro Sanchez-Leon CLA 2014-12-09 10:42:30 EST
This feature is now merged to master ! 

Thanks a lot Marc K. for all your valuable comments, dedication and contribution to this feature.  

I will update the N&N before marking this bug as fixed.
Comment 6 Alvaro Sanchez-Leon CLA 2014-12-09 17:51:09 EST
New and Noteworthy for CDT 8.6 have been updated

see: https://wiki.eclipse.org/CDT/User/NewIn86